[webkit-reviews] review denied: [Bug 101867] Crash during conversion of element to QVariant : [Attachment 173518] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 10:21:50 PST 2012


Geoffrey Garen <ggaren at apple.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 101867: Crash during conversion of element to QVariant
https://bugs.webkit.org/show_bug.cgi?id=101867

Attachment 173518: Patch
https://bugs.webkit.org/attachment.cgi?id=173518&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
The old code tried to create a null string. The new code tries to create an
empty string. This seems like a change in behavior.

Why should we change fundamental low-level behavior that has been this way for
four years because of a crash in the Qt port?


More information about the webkit-reviews mailing list