[webkit-reviews] review denied: [Bug 101947] Don't mark scrolling contents as dirty if RenderLayerBacking is going away : [Attachment 173663] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Sami Kyöstilä
<skyostil at chromium.org>'s request for review:
Bug 101947: Don't mark scrolling contents as dirty if RenderLayerBacking is
going away
https://bugs.webkit.org/show_bug.cgi?id=101947

Attachment 173663: Patch
https://bugs.webkit.org/attachment.cgi?id=173663&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173663&action=review


> Source/WebCore/ChangeLog:16
> +	   track repaints or not. If the RenderLayerBacking is being destroyed,
the
> +	   compositor is no longer valid and this causes a crash.

This seems like the wrong way to fix the crash. Does 'no longer valid' mean
null, or garbage? if the latter, we need to null out a pointer somewhere.