[webkit-reviews] review denied: [Bug 101192] [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled : [Attachment 173595] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mihai Maerean <mmaerean at adobe.com>'s
request for review:
Bug 101192: [CSSRegions] when WebKit uses V8, there should be a single variable
to store if the CSS Regions feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=101192

Attachment 173595: Patch
https://bugs.webkit.org/attachment.cgi?id=173595&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173595&action=review


This isn't how we normally handle these cases.	Why not just have Chromium use
WebSettings to enable Regions?

> Source/WebCore/page/Settings.cpp:218
> -#if ENABLE(CSS_REGIONS)
> +#if ENABLE(CSS_REGIONS) && !USE(V8)

We generally don't have USE(V8) ifdefs in Settings.cpp....