[webkit-reviews] review granted: [Bug 101854] BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themselves : [Attachment 173485] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 101854: BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable
with themselves
https://bugs.webkit.org/show_bug.cgi?id=101854

Attachment 173485: Patch
https://bugs.webkit.org/attachment.cgi?id=173485&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173485&action=review


r=me with some minor tweaks.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:131
> +    // Other clip-path operations then BasicShapes can not be animated.

s/then/than/

> Source/WebCore/rendering/style/BasicShapes.cpp:65
> +    return result;

We should use "return result.release();" here.

> Source/WebCore/rendering/style/BasicShapes.cpp:90
> +    return result;

Ditto.

> Source/WebCore/rendering/style/BasicShapes.cpp:116
> +    return result;

Ditto.