[webkit-reviews] review denied: [Bug 101563] Add support for fractional scroll events : [Attachment 173584] Add support for fractional scroll events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 09:00:40 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tai-Hsu Lin
<sheckylin at chromium.org>'s request for review:
Bug 101563: Add support for fractional scroll events
https://bugs.webkit.org/show_bug.cgi?id=101563

Attachment 173584: Add support for fractional scroll events
https://bugs.webkit.org/attachment.cgi?id=173584&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173584&action=review


> Source/WebCore/platform/ScrollAnimatorNone.h:105
> +#if PLATFORM(CHROMIUM)
>      virtual void scrollBy(const IntPoint&);
> +#else
> +    virtual void scrollBy(const FloatPoint&);
> +#endif

Platform #ifdefs like this in shared files are not cool. You should change
everyone to FloatPoint, or no-one.


More information about the webkit-reviews mailing list