[webkit-reviews] review granted: [Bug 101841] Web Inspector: migrate text editor to mutation observers : [Attachment 173626] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 101841: Web Inspector: migrate text editor to mutation observers
https://bugs.webkit.org/show_bug.cgi?id=101841

Attachment 173626: Patch
https://bugs.webkit.org/attachment.cgi?id=173626&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173626&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2147
> +	       if (mutation.addedNodes.length === 1 &&
mutation.addedNodes[0].nodeName === "BR")

remove br check?

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2211
>	       // Ensure that the newly inserted line row has no lineNumber.

Shouldn't it be assert?