[webkit-reviews] review denied: [Bug 101838] [Qt] Flash-plugin causes crash on exit : [Attachment 173450] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 101838: [Qt] Flash-plugin causes crash on exit
https://bugs.webkit.org/show_bug.cgi?id=101838

Attachment 173450: Patch
https://bugs.webkit.org/attachment.cgi?id=173450&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173450&action=review


This makes sense to apply to the 2.3 branch I guess, but for landing in trunk
the EWS warning is true: We can't use QWidget::clearFocus() in WebCore/plugins.
One way around it would be to add a helper method to QWebPAgeClient
(clearPluginFocus(QObject* plugin)) for example.

> Source/WebCore/ChangeLog:8
> +	   Drop focus of the pluginview before dettaching it, otherwise it will
cause the focus to shift,

dettaching -> detaching :)