[webkit-reviews] review granted: [Bug 101916] Refactoring: set read-only values on layout in DateTimeEditElement : [Attachment 173605] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 101916: Refactoring: set read-only values on layout in DateTimeEditElement
https://bugs.webkit.org/show_bug.cgi?id=101916

Attachment 173605: Patch
https://bugs.webkit.org/attachment.cgi?id=173605&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review


> Source/WebCore/ChangeLog:5
> +	   Need the bug URL (OOPS!).

Remove this.

> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163
> +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior)


I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue()
might sound better.