[webkit-reviews] review granted: [Bug 101913] Remove HTMLInputElement dependency from PickerIndicatorElement : [Attachment 173596] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kunihiko Sakamoto
<ksakamoto at chromium.org>'s request for review:
Bug 101913: Remove HTMLInputElement dependency from PickerIndicatorElement
https://bugs.webkit.org/show_bug.cgi?id=101913

Attachment 173596: Patch
https://bugs.webkit.org/attachment.cgi?id=173596&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173596&action=review


The code looks ok.  One comment.

> Source/WebCore/html/shadow/PickerIndicatorElement.h:53
> +	   virtual bool isPickerIndicatorOwnerDisabled() const = 0;
> +	   virtual bool isPickerIndicatorOwnerReadOnly() const = 0;

They are called together every time.  So we may merge them into one function
like isPickerIndicatorOwnerDisabledOrReadOnly(). This pattern is used in
FieldOwner in WebCore/html/shadow/DateTimeFieldElement.h.