[webkit-reviews] review denied: [Bug 101907] Web Inspector: Extract common interface for StatusBarButton and StatusBarCombo : [Attachment 173579] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 101907: Web Inspector: Extract common interface for StatusBarButton and
StatusBarCombo
https://bugs.webkit.org/show_bug.cgi?id=101907

Attachment 173579: Patch
https://bugs.webkit.org/attachment.cgi?id=173579&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173579&action=review


> Source/WebCore/inspector/front-end/CPUProfileView.js:74
> +    this.focusButton.setDisabled(true);

If we change the API, I would introduce setEnabled.

> Source/WebCore/inspector/front-end/StatusBarButton.js:34
> +WebInspector.StatusBarItem = function()

Where is it used? Maybe it should have default implementation that manages
element's state based on the calls below? I.e. be not an interface, but a base
class?