[webkit-reviews] review denied: [Bug 101556] Add tests for month picker : [Attachment 173544] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 101556: Add tests for month picker
https://bugs.webkit.org/show_bug.cgi?id=101556

Attachment 173544: Patch
https://bugs.webkit.org/attachment.cgi?id=173544&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173544&action=review


>
LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-opera
tions.html:80
> +    eventSender.keyDown('\n');
> +    shouldBeNull('document.getElementById("mock-page-popup")');

Unfortunately this doesn't work any more because popup close operation is now
asynchronous.
http://trac.webkit.org/changeset/134180

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-opera
tions.html:102
> +    eventSender.keyDown('\x1B');
> +    shouldBeNull('document.getElementById("mock-page-popup")');

ditto.

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-mouse-ope
rations.html:44
> +   
clickElement(popupWindow.document.querySelectorAll(".day:not(.week-column)")[6]
);
> +    shouldBeNull('document.getElementById("mock-page-popup")');

Ditto.

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-with-step
.html:31
> +    // Close popup
> +    eventSender.keyDown('\x1B');
> +
> +    document.getElementById('month').min = "2011-05";
> +    document.getElementById('month').value = "2012-02";
> +    
> +    // Reopen popup
> +    openPicker(document.getElementById('month'), test2);

ditto.