[webkit-reviews] review granted: [Bug 101837] [chromium] move TestRunner implementation into WebTestRunner namespace : [Attachment 173447] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 11 15:17:34 PST 2012


Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 101837: [chromium] move TestRunner implementation into WebTestRunner
namespace
https://bugs.webkit.org/show_bug.cgi?id=101837

Attachment 173447: Patch
https://bugs.webkit.org/attachment.cgi?id=173447&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173447&action=review


> Tools/DumpRenderTree/chromium/DRTTestRunner.h:65
>  

Can we just add "using WebTestRunner:: CppArgumentList" for the various parts
of CppBoundClass that we're using here?  It seems like a waste to qualify all
these types with namespaces when we're just going to move them later.


More information about the webkit-reviews mailing list