[webkit-reviews] review canceled: [Bug 101859] Use prefix form of increment / decrement operators in WTF String classes when possible : [Attachment 173500] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 11 09:47:53 PST 2012


Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 101859: Use prefix form of increment / decrement operators in WTF String
classes when possible
https://bugs.webkit.org/show_bug.cgi?id=101859

Attachment 173500: Patch
https://bugs.webkit.org/attachment.cgi?id=173500&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Remove the comment about efficiency from the Changelog since all changes relate
to primitive types and it does not affect performance in this case as Kling
rightfully mentioned.

Is it right that we have such coding convention in WebKit though?
This patch was basically a follow up to
https://bugs.webkit.org/show_bug.cgi?id=101257#c22 : 
"Typically ++i in WebKit style."


More information about the webkit-reviews mailing list