[webkit-reviews] review granted: [Bug 101851] Including <CoreText/CoreText.h> breaks the chromium/mac build. : [Attachment 173478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 15:01:05 PST 2012


mitz at webkit.org <mitz at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 101851: Including <CoreText/CoreText.h> breaks the chromium/mac build.
https://bugs.webkit.org/show_bug.cgi?id=101851

Attachment 173478: Patch
https://bugs.webkit.org/attachment.cgi?id=173478&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173478&action=review


> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:34
> +#if PLATFORM(WX) || PLATFORM(CHROMIUM)
> +#include <ApplicationServices/ApplicationServices.h>
> +#else
>  #include <CoreText/CoreText.h>
> +#endif

This is not necessary. ApplicationServices.h can be used everywhere.


More information about the webkit-reviews mailing list