[webkit-reviews] review granted: [Bug 99660] checkbox to toggle FPS counter in the inspector's settings : [Attachment 173387] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 11:27:13 PST 2012


Pavel Feldman <pfeldman at chromium.org> has granted egraether at chromium.org's
request for review:
Bug 99660: checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660

Attachment 173387: Patch
https://bugs.webkit.org/attachment.cgi?id=173387&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173387&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:277
> +	  
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show FPS
meter"), WebInspector.settings.showFPSCounter));

One last nit prior to landing: please add this new string into
WebCore/English.lproj/localizedStrings.js


More information about the webkit-reviews mailing list