[webkit-reviews] review denied: [Bug 101495] Web Inspector: styled logs should work with multiple log() arguments : [Attachment 173453] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 101495: Web Inspector: styled logs should work with multiple log()
arguments
https://bugs.webkit.org/show_bug.cgi?id=101495

Attachment 173453: Patch
https://bugs.webkit.org/attachment.cgi?id=173453&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173453&action=review


> Source/WebCore/inspector/front-end/ConsoleMessage.js:477
> +	   var currentStyle = {};

You probably mean var currentStyle = null; here.

> Source/WebCore/inspector/front-end/ConsoleMessage.js:523
> +			   if (currentStyle.hasOwnProperty(key))

You don't need this check: enumerable properties on the object created with {}
is what you need.

> LayoutTests/inspector/console/console-format-style.html:9
> +		   console.log('%cRed! %cRed!', 'color: blue;', 'color: red;');


%cBlue! %cRed!