[webkit-reviews] review granted: [Bug 101691] [V8] Clean up header includes and ifdefs in V8GCController : [Attachment 173178] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 9 20:13:42 PST 2012
Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 101691: [V8] Clean up header includes and ifdefs in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=101691
Attachment 173178: Patch
https://bugs.webkit.org/attachment.cgi?id=173178&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
> Qt and GTK used to have an option to build with V8. These ifdefs were added
to support that, but they no longer have that option.
OK. BTW, then it seems that UseV8.cmake is no longer needed. UseV8.cmake
already lacks a bunch of V8 binding files and it looks like they have not been
maintained.
More information about the webkit-reviews
mailing list