[webkit-reviews] review denied: [Bug 101825] Rename the LOG() macro to LOG_INFO() : [Attachment 173422] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 18:23:38 PST 2012


Darin Adler <darin at apple.com> has denied Dana Jansens <danakj at chromium.org>'s
request for review:
Bug 101825: Rename the LOG() macro to LOG_INFO()
https://bugs.webkit.org/show_bug.cgi?id=101825

Attachment 173422: Patch
https://bugs.webkit.org/attachment.cgi?id=173422&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173422&action=review


> Source/WTF/ChangeLog:9
> +	   The current macro name conflicts with a macro from the chromium
base/
> +	   library. This conflict makes it very difficult to include headers
from

But this macro predates the Chromium base library by many years. Chromium
should change, not WebKit.

> Source/WTF/ChangeLog:14
> +	   By renaming the macro to LOG_INFO() we avoid conflicts, and give the

> +	   macro a more descriptive name as well.

How does “info” make the name more descriptive? Isn’t everything in a computer
“information”?


More information about the webkit-reviews mailing list