[webkit-reviews] review granted: [Bug 101799] SimpleFontData::getCFStringAttributes sets some attributes to their default values, =?UTF-8?Q?=20but=20shouldn=E2=80=99t=20?=: [Attachment 173370] Only include attributes with non-default values

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 101799: SimpleFontData::getCFStringAttributes sets some attributes to their
default values, but shouldn’t
https://bugs.webkit.org/show_bug.cgi?id=101799

Attachment 173370: Only include attributes with non-default values
https://bugs.webkit.org/attachment.cgi?id=173370&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173370&action=review


> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:42
> +   
attributesDictionary.adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 4,
&kCFCopyStringDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));

This is a fairly magical "4".

> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:55
> +	   static int zero = 0;

Why not a "const"?