[webkit-reviews] review granted: [Bug 101800] Correct scroll adjustment for touchEvent.clientX/clientY : [Attachment 173373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 14:55:36 PST 2012


Adam Barth <abarth at webkit.org> has granted Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 101800: Correct scroll adjustment for touchEvent.clientX/clientY
https://bugs.webkit.org/show_bug.cgi?id=101800

Attachment 173373: Patch
https://bugs.webkit.org/attachment.cgi?id=173373&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173373&action=review


> LayoutTests/fast/events/touch/touch-scaled-scrolled.html:17
> +    if (window.internals) {
> +	   window.internals.settings.setPageScaleFactor(2, 0, 0);
> +    }

No need for { } here.

> LayoutTests/fast/events/touch/touch-scaled-scrolled.html:30
> +	   window.setTimeout(function() { window.testRunner.notifyDone(); },
0);

Why do we need to use setTimeout?  Can't we call notifyDone from inside
touched?


More information about the webkit-reviews mailing list