[webkit-reviews] review granted: [Bug 100550] No tests for changing mouse cursors : [Attachment 173368] Merge with ToT

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Rick Byers <rbyers at chromium.org>'s
request for review:
Bug 100550: No tests for changing mouse cursors
https://bugs.webkit.org/show_bug.cgi?id=100550

Attachment 173368: Merge with ToT
https://bugs.webkit.org/attachment.cgi?id=173368&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173368&action=review


> Source/WebCore/testing/Internals.cpp:1531
> +    return "UNKNOWN";

This should be ASSERT_NOT_REACHED(), right?

> Source/WebCore/testing/Internals.cpp:1545
> +    String result = String("type=") + cursorTypeToString(cursor.type())

You should use StringBuilder because you're got a conditional in here.