[webkit-reviews] review granted: [Bug 101647] PDFPlugin should support clicking on external links : [Attachment 173354] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 101647: PDFPlugin should support clicking on external links
https://bugs.webkit.org/show_bug.cgi?id=101647

Attachment 173354: patch
https://bugs.webkit.org/attachment.cgi?id=173354&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173354&action=review


> Source/WebKit2/PluginProcess/PluginControllerProxy.h:142
> +    void shouldAllowScripting(bool&);

Is this still needed?

> Source/WebKit2/WebProcess/Plugins/Plugin.h:197
> +    // Ask the plug-in whether it should be allowed to execute JavaScript or
navigate to JavaScript URLs.

This comment seems a bit misleading, we have no intention to ask plug-ins about
such things.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1647
> +	       if (pluginView && !pluginView->shouldAllowScripting())

The first null check is redundant.