[webkit-reviews] review denied: [Bug 101133] Crash when replacing parts of text inputs with content: url(...) : [Attachment 172749] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Takashi Sakamoto <tasak at google.com>'s
request for review:
Bug 101133: Crash when replacing parts of text inputs with content: url(...)
https://bugs.webkit.org/show_bug.cgi?id=101133

Attachment 172749: Patch
https://bugs.webkit.org/attachment.cgi?id=172749&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172749&action=review


I think we need some sort of ASSERT or other guard in the C++ code to make sure
we don't ever hit this again.  Right now if we removed that line we would start
having this crash again. I suspect that's true of many lines in our UA file,
but it still seems worthy of a C++ ASSERT to validate our understanding of the
code's limitations.

>> Source/WebCore/css/html.css:439
>> +	content: none !important;
> 
> Do !important rules in author style sheets not override ones in the UA sheet?


UA sheets win:
http://www.w3.org/TR/CSS2/cascade.html#cascading-order