[webkit-reviews] review granted: [Bug 101682] RemoveFormat command doesn't remove background color : [Attachment 173196] Fixes the bug

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 101682: RemoveFormat command doesn't remove background color
https://bugs.webkit.org/show_bug.cgi?id=101682

Attachment 173196: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=173196&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173196&action=review


> Source/WebCore/editing/RemoveFormatCommand.cpp:92
> +    defaultStyle->style()->setProperty(CSSPropertyBackgroundColor,
"transparent");

Can we pass in CSSValueTransparent instead of "transparent"?  Looks like that
would avoid having to run the CSS parser.

>>>
LayoutTests/editing/execCommand/remove-format-background-color-expected.txt:3
>>> +hello world WebKit.
>> 
>> Should we use something other than a dumpAsText test?  I think a script test
that uses getComputedStyle or a reftest would be better for checking the
background color.
> 
> I’m dumping HTML here. We don’t want to leave a span. It’s important the
markup we generate is as concise as possible.

Ah, I see.  Using dump-as-markup.js would be more clear.  Should there be a
test case with background-color: transparent?