[webkit-reviews] review granted: [Bug 101777] NetworkRequest refactoring : [Attachment 173338] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 101777: NetworkRequest refactoring
https://bugs.webkit.org/show_bug.cgi?id=101777

Attachment 173338: Patch v1
https://bugs.webkit.org/attachment.cgi?id=173338&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173338&action=review


Seems OK to land, although I don't think that we'll have all of these
necessarily implemented.

> Source/WebKit2/NetworkProcess/NetworkRequest.cpp:188
> +    notImplemented();

I don't know if notImplemented is of any use here. I think it's not.

You are not saying that all these callbacks should be implemented differently,
and the platform you are working on doesn't do anything in notImplemented
AFAIK.