[webkit-reviews] review denied: [Bug 101775] [Qt] MiniBrowser should not strongly depend on QtTestSupport. : [Attachment 173331] Patch

[bugzilla-daemon at webkit.org]

Zeno Albisser <zeno at webkit.org> has denied Zeno Albisser <zeno at webkit.org>'s
request for review:
Bug 101775: [Qt] MiniBrowser should not strongly depend on QtTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=101775

Attachment 173331: Patch
https://bugs.webkit.org/attachment.cgi?id=173331&action=review

------- Additional Comments from Zeno Albisser <zeno at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173331&action=review


>> Source/WebCore/Target.pri:4079
>> +if(build?(qttestsupport)) {
> 
> This should probably be have?(qttestsupport), which should fix the build.

No, that is intentional. As it is translated from build to have in
features.prf.

> Source/WebCore/platform/qt/QtTestSupport.h:27
> +#if HAVE(QTTESTSUPPORT)

But these one here is evil. I should have known better. :-)