[webkit-reviews] review granted: [Bug 101768] [CSSRegions] Region styling properties are not filtered correctly : [Attachment 173328] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 101768: [CSSRegions] Region styling properties are not filtered correctly
https://bugs.webkit.org/show_bug.cgi?id=101768

Attachment 173328: Patch
https://bugs.webkit.org/attachment.cgi?id=173328&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173328&action=review


r=me

This bug really caught me by surprise. I suspect we may have more of them
elsewhere.

Note that we're using "unsigned : 1" for bool fields because some Windows
compiler (MSVC?) refuses to put signed and unsigned members in the same
bitfield, causing struct bloat.

> Source/WebCore/css/RuleSet.cpp:121
> -    , m_isInRegionRule(addRuleFlags & RuleIsInRegionRule)
> +    , m_isInRegionRule((bool)(addRuleFlags & RuleIsInRegionRule))

Anders says that !!(addRuleFlags & RuleIsInRegionRule) is better here, and I
guess I agree.