[webkit-reviews] review granted: [Bug 101767] [chromium] Use devicePixelRatio instead of screen DPI for computing viewport attributes : [Attachment 173318] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 09:33:43 PST 2012


Adam Barth <abarth at webkit.org> has granted Sami Kyöstilä
<skyostil at chromium.org>'s request for review:
Bug 101767: [chromium] Use devicePixelRatio instead of screen DPI for computing
viewport attributes
https://bugs.webkit.org/show_bug.cgi?id=101767

Attachment 173318: Patch
https://bugs.webkit.org/attachment.cgi?id=173318&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173318&action=review


> Source/WebKit/chromium/src/ChromeClientImpl.cpp:625
> -    float devicePixelRatio = dpi / ViewportArguments::deprecatedTargetDPI;
> +    float devicePixelRatio =
m_webView->client()->screenInfo().deviceScaleFactor;

m_webView->client() -> client

(We already have the client in a local variable.


More information about the webkit-reviews mailing list