[webkit-reviews] review granted: [Bug 100937] [BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key : [Attachment 173220] patch - updated

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 100937: [BlackBerry] DRT - eventSender.keyDown() needs to support pageUp,
pageDown, home, end key
https://bugs.webkit.org/show_bug.cgi?id=100937

Attachment 173220: patch - updated
https://bugs.webkit.org/attachment.cgi?id=173220&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173220&action=review


LGTM.

> Tools/ChangeLog:12
> +	   KeyUp event in InputHandler::handleKeyboardInput().

No PR?

> Tools/DumpRenderTree/blackberry/EventSender.cpp:185
> +    page->keyEvent(BlackBerry::Platform::KeyboardEvent(charCode,
BlackBerry::Platform::KeyboardEvent::KeyUp, modifiers));

We should be considering using BlackBerry::Platform::KeyboardEvent; to get rid
of the namespaces. You'd need just KeyboardEvent then.