[webkit-reviews] review denied: [Bug 101591] Web Inspector: Ctrl+a in the network panel should select resource content, not the entire panel : [Attachment 173223] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 101591: Web Inspector: Ctrl+a in the network panel should select resource
content, not the entire panel
https://bugs.webkit.org/show_bug.cgi?id=101591

Attachment 173223: Patch
https://bugs.webkit.org/attachment.cgi?id=173223&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173223&action=review


> Source/WebCore/ChangeLog:14
> +	   * inspector/front-end/KeyboardShortcut.js: Added SELECT_ALL constant
for Ctrl+A combination

SelectAll

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:412
>	   this._shortcuts[WebInspector.KeyboardShortcut.makeKey("z",
modifiers.Shift | modifiers.CtrlOrMeta)] = handleRedo;

I would group together all the code dealing with redo here.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:433
> +	   if (this.readOnly() && shortcutKey !==
WebInspector.KeyboardShortcut.SelectAll)

This is odd. We would need to add such a check for each shortcut supported in
read only mode that we add.
I'd rather move readOnly check to handlers.