[webkit-reviews] review granted: [Bug 100611] CSS canvas renders blurry at 2x pixel ratio : [Attachment 171143] Proposed Change

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 100611: CSS canvas renders blurry at 2x pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=100611

Attachment 171143: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=171143&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171143&action=review


> LayoutTests/ChangeLog:3
> +	   Test if -webkit-canvas in CSS uses the full backing store instead of
alway 1x when rendering.

Typo: always

> LayoutTests/fast/canvas/canvas-as-image-hidpi.html:19
> +	   ctx.fillStyle = "rgb(200, 0, 0)";
> +	   ctx.fillRect(10, 10, 50, 50);
> +
> +	   ctx.fillStyle = "rgba(0, 0, 200, 0.5)";
> +	   ctx.fillRect(25, 25, 90, 90);

I'm not sure this will actually test the change. This particular code drawn
into 100x100 and then stretched would be indistinguishable from the 200x200
image. Or am I missing it?

I can't think of a good way to test otherwise though.

> Source/WebCore/ChangeLog:3
> +	   Make -webkit-canvas in CSS use the full backing store instead of
alway 1x when rendering.

Typo: always

> Source/WebCore/platform/graphics/ImageBuffer.h:81
> +    enum Scale {
> +	   Scaled,
> +	   Unscaled
> +    };

Should this be called ScaleBehavior or something? Scale is a slightly ambiguous
word.