[webkit-reviews] review granted: [Bug 101693] Web Inspector: Always use textured window for the Web Inspector : [Attachment 173180] Proposed Change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 20:07:42 PST 2012


Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 101693: Web Inspector: Always use textured window for the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=101693

Attachment 173180: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=173180&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173180&action=review


> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:344
> +    [window setContentBorderThickness:55. forEdge:NSMaxYEdge];

Nit: "55." isn't normal number style. You can fix this, or just cq+ since its
not changing from the old code.


More information about the webkit-reviews mailing list