[webkit-reviews] review denied: [Bug 101499] [Chromium-Android] Special word selection rules : [Attachment 173067] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 101499: [Chromium-Android] Special word selection rules
https://bugs.webkit.org/show_bug.cgi?id=101499

Attachment 173067: Patch
https://bugs.webkit.org/attachment.cgi?id=173067&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173067&action=review


> Source/WebCore/editing/android/VisibleSelectionAndroid.cpp:51
> +    // Don't expand beyond '.' for word granularity.
> +    VisiblePosition originalStart = m_start;
> +    validate(granularity);

No, this is what you want to modify. You want to do this at much lower level by
overriding ICU's behavior.
Modify findNextWordFromIndex in TextBoundaries.cpp. You probably want to add
TextBoundariesAndroid.cpp.