[webkit-reviews] review denied: [Bug 101655] [BlackBerry] Adding a sound to touch events on anchor elements : [Attachment 173138] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied otcheung at rim.com's request for
review:
Bug 101655: [BlackBerry] Adding a sound to touch events on anchor elements
https://bugs.webkit.org/show_bug.cgi?id=101655

Attachment 173138: Patch
https://bugs.webkit.org/attachment.cgi?id=173138&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173138&action=review


why instead of the client calling this Api, why not make TouchEventHandler to
do it on single touch/mouse up?

> Source/WebKit/blackberry/Api/WebPage.h:159
> +    void playSoundOnAnchorElementTouchEvents();

bad naming imo

something around "play sound if anchor is the target" would read better

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:187
> +void TouchEventHandler::playSoundOnAnchorElementTouchEvents()

const?