[webkit-reviews] review granted: [Bug 77028] percent width includes borders and paddings on CSS tables : [Attachment 173029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 17:36:24 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 77028: percent width includes borders and paddings on CSS tables
https://bugs.webkit.org/show_bug.cgi?id=77028

Attachment 173029: Patch
https://bugs.webkit.org/attachment.cgi?id=173029&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173029&action=review


I don't need to see the updated patch.

> Source/WebCore/ChangeLog:12
> +	   This was already handled for fixed width CSS tables but not for
percent
> +	   width tables.

The ChangeLog seems stale as you handle any specified length. Also please
rename the bug to cover the extended use case (which includes updating the
tests).

> LayoutTests/fast/table/css-table-width-with-border-padding.html:86
> +    <!-- For box-sizing: padding-box (not supported) -->

You should probably mention that the results as checking in are wrong: because
we don't support box-sizing: padding-box, the results are 100px longer.

You could also check in the expected result. I don't feel strongly about the 2
options (which are equivalent). Filing a bug or commenting on the box-sizing:
padding-box change is important in both cases.


More information about the webkit-reviews mailing list