[webkit-reviews] review canceled: [Bug 45110] Implement JSC features required for IndexedDB : [Attachment 169813] Implement IndexedDB for JSC

[bugzilla-daemon at webkit.org]

Michael Pruett <michael at 68k.org> has canceled Michael Pruett
<michael at 68k.org>'s request for review:
Bug 45110: Implement JSC features required for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45110

Attachment 169813: Implement IndexedDB for JSC
https://bugs.webkit.org/attachment.cgi?id=169813&action=review

------- Additional Comments from Michael Pruett <michael at 68k.org>
I've updated this patch in accordance with other recent changes to IndexedDB.
In particular I've removed the custom bindings for IDBCursorWithValue.

> > Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:105
> > +	 const IDBIndexMetadata& indexMetadata,
>
> Indentation here is odd.

Unfortunately the indentation in the file currently no longer passes
check-webkit-style, so retaining the current indentation would seem not to be
an option. I would be happy to change the indentation to any style you suggest.


> > Source/WebCore/bindings/js/SerializedScriptValue.cpp:1845
> > +	 if (m_data.size() & 1) {
>
> Looks like a similar fix to https://bugs.webkit.org/show_bug.cgi?id=99310
>
> Include the test case?

The only place the JSC implementation of SerializedScriptValue::toWireString()
is called is in IDBObjectStoreBackendImpl::putInternal(). This change is
covered by numerous tests in storage/indexeddb, including the following which
fail without this change:

storage/indexeddb/cursor-delete.html
storage/indexeddb/cursor-inconsistency.html
storage/indexeddb/cursor-key-order.html
storage/indexeddb/cursor-prev-no-duplicate.html
storage/indexeddb/cursor-value.html
storage/indexeddb/database-close.html
storage/indexeddb/factory-deletedatabase.html
storage/indexeddb/index-multientry.html
storage/indexeddb/index-population.html
storage/indexeddb/mutating-cursor.html
storage/indexeddb/mozilla/put-get-values.html
storage/indexeddb/odd-strings.html
storage/indexeddb/open-cursor.html
storage/indexeddb/transaction-rollback.html
storage/indexeddb/two-version-changes.html
storage/indexeddb/value-undefined.html
storage/indexeddb/values-odd-types.html