[webkit-reviews] review granted: [Bug 101644] Fixed header on Facebook news feed becomes detached from top of viewport after rubber band scrolling : [Attachment 173118] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 101644: Fixed header on Facebook news feed becomes detached from top of
viewport after rubber band scrolling
https://bugs.webkit.org/show_bug.cgi?id=101644

Attachment 173118: Patch
https://bugs.webkit.org/attachment.cgi?id=173118&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173118&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:88
> +IntSize scrollOffsetForFixedPosition(const IntRect visibleContentRect, const
IntSize contentsSize, const IntPoint scrollPosition, const IntPoint
scrollOrigin, float frameScaleFactor, bool fixedElementsLayoutRelativeToFrame)

All the const IntFoo should be references.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:281
> +	       LayoutRect viewportRect = IntRect(scrollOffsetForFixed.width(),
scrollOffsetForFixed.height(), visibleContentRect.width(),
visibleContentRect.height());

I think we have toPoint() and toSize() now.

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:285
> +    IntRect viewportRect = IntRect(scrollOffsetForFixedChildren.width(),
scrollOffsetForFixedChildren.height(), viewportSize.width(),
viewportSize.height());

Here you can just do 

viewportRect = this->viewportRect();
viewportRect.setLocation(toInt(scrollOffsetForFixedChildren)).