[webkit-reviews] review granted: [Bug 101527] CSS charset parsing is too loose, doesn't match other browsers : [Attachment 173136] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tab Atkins
<tabatkins at google.com>'s request for review:
Bug 101527: CSS charset parsing is too loose, doesn't match other browsers
https://bugs.webkit.org/show_bug.cgi?id=101527

Attachment 173136: Patch
https://bugs.webkit.org/attachment.cgi?id=173136&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> Yeah, I'm not sure exactly when IE changed.  

I wonder if they still do the old thing in quirks mode.

> If I could figure out how to determine when a file was added to the repo, I
could establish a lower bound at least.  ^_^

One of the ways is to go to
<http://trac.webkit.org/browser/trunk/LayoutTests/fast/encoding/css-charset-evi
l.html>, and click "Revision Log". Alternatively, "svn log" on command line
would do it.

6 years.

> I didn't know that I was supposed to clean up that section of the ChangeLog. 
Done!

Most reviewers are very lax with this, I was just spiteful because my old fix
was being undone ;). More seriously, the goal is to make reading patches and
history as easy as possible, and removing garbage lines helps a little.