[webkit-reviews] review denied: [Bug 101646] [BlackBerry] Disable cookies on file:// : [Attachment 173123] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied otcheung at rim.com's request for review:
Bug 101646: [BlackBerry] Disable cookies on file://
https://bugs.webkit.org/show_bug.cgi?id=101646

Attachment 173123: Patch
https://bugs.webkit.org/attachment.cgi?id=173123&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173123&action=review


Almost there.

> Source/WebCore/platform/blackberry/CookieManager.cpp:129
> +static bool shouldIgnoreScheme(const String protocol)

Use &.

> Source/WebCore/platform/blackberry/CookieManager.cpp:243
> +    // We only want to enable them if the webworks app enabled a flag for it
(m_shouldDumpAllCookies)

Periods at end of sentences.