[webkit-reviews] review denied: [Bug 100589] ASSERT problem on MIPS : [Attachment 173095] ASSERT fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 12:34:09 PST 2012


Oliver Hunt <oliver at apple.com> has denied Balazs Kilvady
<kilvadyb at homejinni.com>'s request for review:
Bug 100589: ASSERT problem on MIPS
https://bugs.webkit.org/show_bug.cgi?id=100589

Attachment 173095: ASSERT fix.
https://bugs.webkit.org/attachment.cgi?id=173095&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173095&action=review


> Source/JavaScriptCore/jit/JITOpcodes.cpp:1631
>	       ASSERT(!value);

Can't this just be ASSERT(value == regT0) ?


More information about the webkit-reviews mailing list