[webkit-reviews] review granted: [Bug 101440] [Chromium] Arabic digits should appear left-to-right : [Attachment 172741] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 12:30:05 PST 2012


Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 101440: [Chromium] Arabic digits should appear left-to-right
https://bugs.webkit.org/show_bug.cgi?id=101440

Attachment 172741: Patch
https://bugs.webkit.org/attachment.cgi?id=172741&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review


> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235
> +    // HarfBuzz when we are calculating widths (except for
directionalOverride() is set).

"except when directionOverride() is set" reads better in English.


More information about the webkit-reviews mailing list