[webkit-reviews] review denied: [Bug 101628] [BlackBerry] Provide pixel coordinates to IMF relative to the screen : [Attachment 173085] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 101628: [BlackBerry] Provide pixel coordinates to IMF relative to the
screen
https://bugs.webkit.org/show_bug.cgi?id=101628

Attachment 173085: Patch
https://bugs.webkit.org/attachment.cgi?id=173085&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173085&action=review


Some stuff to fix still.

> Source/WebKit/blackberry/ChangeLog:8
> +	   Need the bug URL (OOPS!).

You have two descriptions :) Please merge them.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:758
> +			      , spellCheckingOptionRequest.startTextPosition,
spellCheckingOptionRequest.endTextPosition);

The IntPoint will not work with %d.