[webkit-reviews] review granted: [Bug 101515] HashAndUTF8CharactersTranslator should create an 8 bit string if possible : [Attachment 172880] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 101515: HashAndUTF8CharactersTranslator should create an 8 bit string if
possible
https://bugs.webkit.org/show_bug.cgi?id=101515

Attachment 172880: Patch
https://bugs.webkit.org/attachment.cgi?id=172880&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Changes like this are better if the change log or comments state why we are
doing this. I know why, but I don’t think it’s obvious why this is the right
thing to do. You can imagine a different approach where we actually allocated a
UTF-16 buffer and scanned it and determined the whole thing was Latin-1 even
for non-ASCII cases. Presumably that’s not important, but this optimization is
important. Some brief remark about how you decided to do this is needed. The
change log you have here is entirely mechanical, and it says what the code
does, but what people are interested in more often is why.