[webkit-reviews] review granted: [Bug 101573] [V8] Add context checks to WorldContextHandle and V8DOMWindowShell : [Attachment 172976] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 8 10:18:39 PST 2012
Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 101573: [V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573
Attachment 172976: Patch
https://bugs.webkit.org/attachment.cgi?id=172976&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172976&action=review
Thanks.
> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:471
> + V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<DOMWindow>(window),
windowWrapper);
The explicit call to PassRefPtr<DOMWindow> shouldn't be necessary here.
More information about the webkit-reviews
mailing list