[webkit-reviews] review granted: [Bug 101455] webkitpy/layouttests integration test fails if high shards/processes environment variables are used : [Attachment 173005] Patch, clearing env of WTMLS var.

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 101455: webkitpy/layouttests integration test fails if high
shards/processes environment variables are used
https://bugs.webkit.org/show_bug.cgi?id=101455

Attachment 173005: Patch, clearing env of WTMLS var.
https://bugs.webkit.org/attachment.cgi?id=173005&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173005&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:323
> +	       os.environ["WEBKIT_TEST_MAX_LOCKED_SHARDS"] =
save_env_webkit_test_max_locked_shards

This should be in a try/catch block, otherwise if the test fails the variable
won't be restored. Feel free to land it with that change.