[webkit-reviews] review denied: [Bug 99319] Web Inspector: Update CodeMirror to v3 : [Attachment 173038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 07:37:57 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Jan Keromnes
<janx at chromium.org>'s request for review:
Bug 99319: Web Inspector: Update CodeMirror to v3
https://bugs.webkit.org/show_bug.cgi?id=99319

Attachment 173038: Patch
https://bugs.webkit.org/attachment.cgi?id=173038&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review


> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57
> -    CodeMirror.on(this._codeMirror, "change", this._change.bind(this));

Why this was wrong? It seems to work for me.


More information about the webkit-reviews mailing list