[webkit-reviews] review denied: [Bug 101568] [BlackBerry] need to call closePopup at setValueAndClosePopup : [Attachment 172981] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 101568: [BlackBerry] need to call closePopup at setValueAndClosePopup
https://bugs.webkit.org/show_bug.cgi?id=101568

Attachment 172981: Patch
https://bugs.webkit.org/attachment.cgi?id=172981&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172981&action=review


Code looks good but ChangeLog should be better.

> Source/WebKit/blackberry/ChangeLog:10
> +	   Internally reviewed by Charles Wei.

Please also state PR and internal reviewer.
I think the description could be better, since in the PR it states there is a
freeze/crash which I can't see in this description.