[webkit-reviews] review granted: [Bug 101298] Improve the use of AtomicString with literals : [Attachment 172661] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 101298: Improve the use of AtomicString with literals
https://bugs.webkit.org/show_bug.cgi?id=101298

Attachment 172661: Patch
https://bugs.webkit.org/attachment.cgi?id=172661&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172661&action=review


>> Source/WebCore/Modules/battery/BatteryController.cpp:94
>> +	DEFINE_STATIC_LOCAL(AtomicString, name, ("BatteryController",
AtomicString::ConstructFromLiteral));
> 
> Why does this have to be different syntax than initializing a String? For a
String we construct with an argument of type ASCIILiteral, right? Why did you
chose a different approach for AtomicString?

I’m going to say review+ but I think this is way to awkward syntax for
something so basic, and I’d like us to investigate cleaner syntax that can
generate identical code.