[webkit-reviews] review canceled: [Bug 101588] [Qt] Fix build with MSVC 2012 and Angle : [Attachment 173030] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 101588: [Qt] Fix build with MSVC 2012 and Angle
https://bugs.webkit.org/show_bug.cgi?id=101588

Attachment 173030: Patch
https://bugs.webkit.org/attachment.cgi?id=173030&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173030&action=review


> Source/ThirdParty/ANGLE/Target.pri:27
>  
>  CONFIG += staticlib
>  
> +# Pull in WTF include paths, because for Windows we need
> +# JavaScriptCore/os-win32/stdint.h, which in turn needs wtf/Platform.h
> +defineTest(addIncludePaths) {
> +    # Just needed for include paths
> +    include(../../WTF/WTF.pri)
> +
> +    export(INCLUDEPATH)
> +}
> +
> +addIncludePaths()
> +
>  INCLUDEPATH += \
>      $$SOURCE_DIR/src \
>      $$SOURCE_DIR/src/compiler/preprocessor/new \

Clearing review. After quick discussion and face-to-face review with Tor Arne
I'm removing this part altogether (it shouldn't be needed) and if it works will
land it.