[webkit-reviews] review denied: [Bug 101570] [EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary is loaded : [Attachment 172972] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 101570: [EFL] Add a method to the TextCheckerEnchant class to check whether
any dictionary is loaded
https://bugs.webkit.org/show_bug.cgi?id=101570

Attachment 172972: proposed patch
https://bugs.webkit.org/attachment.cgi?id=172972&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172972&action=review


Mostly a readability/hackability change, so I'll be nit-picky and say
languagesLoaded sounds to me like it would return the languages that have been
loaded. Also, I'd prefer maintaining the "dictionary" terminology, so perhaps
hasDictionary?

> Source/WebCore/ChangeLog:11
> +	   spelling setting is being enabled. This change allows to do not get
> +	   vector of dictionaries to just check its size.

This last sentence is a bit broken. How about "This change makes it more
convenient to check whether the dictionaries vector is empty."?